ahmedabu98 commented on code in PR #35787:
URL: https://github.com/apache/beam/pull/35787#discussion_r2377058970
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/store/InMemoryMetaStore.java:
##########
@@ -112,22 +119,35 @@ private void initTablesFromProvider(TableProvider
provider) {
this.tables.putAll(tables);
}
- Map<String, TableProvider> getProviders() {
+ @Override
+ public Map<String, TableProvider> tableProviders() {
return providers;
}
@Override
public boolean supportsPartitioning(Table table) {
- TableProvider provider = providers.get(table.getType());
- if (provider == null) {
- throw new IllegalArgumentException(
- "No TableProvider registered for table type: " + table.getType());
- }
- return provider.supportsPartitioning(table);
+ return getProvider(table.getType()).supportsPartitioning(table);
}
+ /**
+ * Fetches a {@link TableProvider} for this type. This provider can exist in
the current {@link
+ * InMemoryMetaStore} or a nested {@link InMemoryMetaStore}.
+ *
+ * @param type
+ * @return
+ */
public TableProvider getProvider(String type) {
- return checkArgumentNotNull(
- providers.get(type), "No TableProvider registered for table type: " +
type);
+ @Nullable TableProvider provider = providers.get(type);
Review Comment:
Nice catch, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
