Abacn commented on code in PR #36380:
URL: https://github.com/apache/beam/pull/36380#discussion_r2403259343
##########
.github/workflows/beam_PostCommit_Java_Jpms_Dataflow.yml:
##########
@@ -49,19 +49,19 @@ env:
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
jobs:
- beam_PostCommit_Java_Jpms_Dataflow_Java11:
+ beam_PostCommit_Java_Jpms_Dataflow:
Review Comment:
Java 11 tests just setup with JDK11; while Java17-25 setup with JDK11 +
JDK`<version>`. It runs gradle and compile Beam on Java11, and compiles and run
test class on JDK<version> thus need two workflows. Similar to
https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow.yml?query=event%3Aschedule
(Java 11)
https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_JavaVersions.yml?query=event%3Aschedule
(Java 17 and 21)
##########
.github/workflows/beam_PostCommit_Java_Jpms_Dataflow.yml:
##########
@@ -49,19 +49,19 @@ env:
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
jobs:
- beam_PostCommit_Java_Jpms_Dataflow_Java11:
+ beam_PostCommit_Java_Jpms_Dataflow:
Review Comment:
Java 11 tests just setup with JDK11; while Java17-25 setup with JDK11 +
JDK`<version>`. It runs gradle and compile Beam on Java11, and compiles and run
test class on JDK`<version>` thus need two workflows. Similar to
https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow.yml?query=event%3Aschedule
(Java 11)
https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_JavaVersions.yml?query=event%3Aschedule
(Java 17 and 21)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
