Abacn commented on code in PR #36523:
URL: https://github.com/apache/beam/pull/36523#discussion_r2433479898
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -2016,22 +2014,16 @@ static class OffsetDeduplicationIdExtractor<K, V>
extends DoFn<KafkaRecord<K, V>, KafkaRecord<K, V>> {
@ProcessElement
- public void processElement(ProcessContext pc) {
- KafkaRecord<K, V> element = pc.element();
+ public void processElement(
+ @Element KafkaRecord<K, V> element, OutputReceiver<KafkaRecord<K,
V>> outputReceiver) {
Review Comment:
It removed public facing API, as reflected by the change here, persumably
user used to use ProcessContext.outputWindowedValue also gets affected. Shall
we update CHANGES.md?
https://github.com/apache/beam/blob/ed39503878ef8b6aff8439e0b757068f5f5493a7/CHANGES.md?plain=1#L92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
