shunping commented on code in PR #36412:
URL: https://github.com/apache/beam/pull/36412#discussion_r2408097219
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -285,8 +285,8 @@ func executePipeline(ctx context.Context, wks
map[string]*worker.W, j *jobservic
//slog.Warn("teststream bytes",
"value", string(v), "bytes", v)
return v
}
- // Hack for Java Strings in test stream, since
it doesn't encode them correctly.
- forceLP := cID == "StringUtf8Coder" || cID !=
pyld.GetCoderId()
+ // the coder from teststream payload has to be
LP'ed
+ forceLP := cID != pyld.GetCoderId()
Review Comment:
The java hack is only relevant to "StringUtf8Coder". If the coder has been
LP'ed, we have to the data too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
