reuvenlax commented on code in PR #36425:
URL: https://github.com/apache/beam/pull/36425#discussion_r2443542354


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoIT.java:
##########
@@ -395,6 +422,135 @@ public void testNestedRichTypesAndNull() throws 
IOException, InterruptedExceptio
     assertNull(actualTableRows.get(0).get("nestedValue3"));
   }
 
+  @Test
+  public void testWriteProtosEncodedTypes()
+      throws IOException, InterruptedException,
+          TableRowToStorageApiProto.SchemaConversionException {
+    String tableSpec = createTable(PROTO_ENCODED_TABLE_SCHEMA);
+    final String timestamp = "1970-01-01T00:00:00.000043";
+    final String date = "2019-08-16";
+    final String numeric = "23";
+    final String bignumeric = "123456789012345678";
+    final String datetime = "2019-08-16T00:52:07.123456";
+    final String time = "00:52:07.123456";
+
+    Proto3SchemaMessages.PrimitiveEncodedFields base_row =

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to