lostluck commented on code in PR #36672:
URL: https://github.com/apache/beam/pull/36672#discussion_r2476300752
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1334,10 +1334,13 @@ func (ss *stageState) injectTriggeredBundlesIfReady(em
*ElementManager, window t
}
state := wv[key]
endOfWindowReached := window.MaxTimestamp() < ss.input
+ em.refreshCond.L.Lock()
+ emNow := em.ProcessingTimeNow()
Review Comment:
ProcessingTimeNow() is exported... Are we calling it outside of the engine
package? If not, please unexport it.
Otherwise we'll need to move the lock holding into the method itself to
handle the external caller, and have an internalU unexported version that
requires manual locking.
Essentially, we can't have an exported method that requires holding an
internal lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
