damccorm commented on code in PR #36696:
URL: https://github.com/apache/beam/pull/36696#discussion_r2482121800
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -667,11 +667,8 @@ public boolean advance() throws IOException {
try {
Message message;
synchronized (this) {
- if (receiveTimeoutMillis == 0L) {
- message = this.consumer.receiveNoWait();
- } else {
- message = this.consumer.receive(receiveTimeoutMillis);
- }
+ long timeout = (receiveTimeoutMillis == 0L) ? 1L :
receiveTimeoutMillis;
+ message = this.consumer.receive(timeout);
Review Comment:
Could you explain why we need this change? It seems like we are no longer
respecting the set receive timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
