aIbrahiim commented on code in PR #36718:
URL: https://github.com/apache/beam/pull/36718#discussion_r2490966796
##########
.github/workflows/beam_PostCommit_Python_ValidatesContainer_Dataflow_With_RC.yml:
##########
@@ -81,6 +81,18 @@ jobs:
with:
java-version: default
python-version: ${{ matrix.python_version }}
+ - name: Authenticate to GCP
+ uses: google-github-actions/auth@v3
+ with:
+ service_account: ${{ secrets.GCP_SA_EMAIL }}
+ credentials_json: ${{ secrets.GCP_SA_KEY }}
+ - name: Set up Cloud SDK
+ uses: google-github-actions/setup-gcloud@v3
+ - name: Configure Docker auth for GCR
+ run: |
+ gcloud --quiet auth configure-docker us.gcr.io
+ gcloud --quiet auth configure-docker gcr.io
+ gcloud auth list
Review Comment:
The working workflow has docker auth steps so I followed that pattern as the
failure was unauthorized authentication failed when the Python test called
docker push, so I wanted to ensure auth was set up early
But you ae right that it's redundant, I will modify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
