kennknowles commented on code in PR #36708:
URL: https://github.com/apache/beam/pull/36708#discussion_r2491393025


##########
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##########
@@ -415,6 +415,12 @@ message ProcessBundleRequest {
   // beam:protocol:control_request_elements_embedding:v1 capability. See more
   // at https://s.apache.org/beam-fn-api-control-data-embedding.
   Elements elements = 3;
+
+  // If "true", SDK will skip state fetch
+  bool key_has_no_state = 4;
+
+  // If "true", SDK will skip state write

Review Comment:
   Bundles are not restricted to have a single key. In fact they very 
frequently have a whole key range. Do these booleans mean that _no_ key in the 
bundle has any state / has any further bundles?
   
   In addition to resolving that issue, please document more fully and focus on 
semantics/specification/requirements.
   
   For example:
   
    - `only_bundle_for_key`: Indicates that the runner will never process 
another bundle for the [keys in this bundle] so state need not be included in 
the bundle commit.
    - `key_has_no_state`: Indicates that the runner has no state for the [keys 
in this bundle] so an SDK can safely begin stateful processing with a 
locally-generated initial empty state.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to