lostluck commented on code in PR #36723:
URL: https://github.com/apache/beam/pull/36723#discussion_r2491992483
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/metrics.proto:
##########
@@ -517,6 +517,10 @@ message MonitoringInfoTypeUrns {
// - sum: beam:coder:varint:v1
// - min: beam:coder:varint:v1
// - max: beam:coder:varint:v1
+ //
+ // Note that when count is zero, the SDK may or may not send sum, min, and
Review Comment:
"may" in specs usually implies the conditional, so we can avoid the "or may
not". I think "omit" here makes it clearer. Same for the paired paragraph below.
```suggestion
// Note that when count is zero, the SDK may omit sum, min, and
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
