gemini-code-assist[bot] commented on code in PR #36801:
URL: https://github.com/apache/beam/pull/36801#discussion_r2519206961
##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -873,9 +848,8 @@ def apply(
def _assert_not_applying_PDone(
self,
- pvalueish, # type: Optional[pvalue.PValue]
- transform # type: ptransform.PTransform
- ):
+ pvalueish: Optional[pvalue.PValue],
+ transform: ptransform.PTransform):
Review Comment:
This function is missing a return type hint. Since it doesn't return a
value, it should be annotated with `-> None` for completeness and consistency
with other type-hinted methods in this file.
```suggestion
transform: ptransform.PTransform) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
