Abacn commented on code in PR #36623: URL: https://github.com/apache/beam/pull/36623#discussion_r2577902661
########## sdks/java/ml/inference/remote/src/main/java/org/apache/beam/sdk/ml/inference/remote/BaseResponse.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.ml.inference.remote; + +import java.io.Serializable; + +/** + * Base class for defining response types returned from remote inference operations. + + * <p>Implementations: + * <ul> + * <li>Contain the inference results (predictions, classifications, generated text, etc.)</li> + * <li>Includes any relevant metadata </li> + * </ul> + * + */ +public abstract class BaseResponse implements Serializable { Review Comment: BaseInput and BaseResponse are both empty. If there isn't non-abstract method it should be an interface. If there are not required methods implemented it can simply be dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
