Abacn commented on code in PR #37014:
URL: https://github.com/apache/beam/pull/37014#discussion_r2629404430
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinationsHelpers.java:
##########
@@ -299,19 +304,42 @@ static class
ConstantTimePartitioningClusteringDestinations<T>
this.jsonClustering = jsonClustering;
}
+ boolean isJsonConfigPresent(String json) {
Review Comment:
this helper method can be static, and taking a ValueProvider<String> as
parameter for further simplification?
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinationsHelpers.java:
##########
@@ -279,6 +279,11 @@ static class
ConstantTimePartitioningClusteringDestinations<T>
private final @Nullable ValueProvider<String> jsonTimePartitioning;
private final @Nullable ValueProvider<String> jsonClustering;
+ // Lazily initialized and cached values.
+ private @Nullable String evaluatedPartitioning = null;
Review Comment:
is there a concern during serialization/deserialization if these strings not
transient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
