damccorm commented on code in PR #37079:
URL: https://github.com/apache/beam/pull/37079#discussion_r2639905799
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageQuerySource.java:
##########
@@ -40,6 +40,38 @@
/** A {@link org.apache.beam.sdk.io.Source} representing reading the results
of a query. */
class BigQueryStorageQuerySource<T> extends BigQueryStorageSourceBase<T> {
+ public static <T> BigQueryStorageQuerySource<T> create(
+ String stepUuid,
+ ValueProvider<String> queryProvider,
+ Boolean flattenResults,
+ Boolean useLegacySql,
+ QueryPriority priority,
+ @Nullable String location,
+ @Nullable String queryTempDataset,
+ @Nullable String queryTempProject,
+ @Nullable String kmsKey,
+ @Nullable DataFormat format,
+ SerializableFunction<SchemaAndRecord, T> parseFn,
+ Coder<T> outputCoder,
+ BigQueryServices bqServices,
+ @Nullable TimestampPrecision picosTimestampPrecision) {
Review Comment:
> It could be feasible to add maxTimestampPrecision as the setting in
BigQueryIO as a way to control what java type is used for timestamps in
general. E.g. LogicalTypes.Timestamp.<MILLIS,MICROS,NANOS>. Is that what you
are thinking?
Yeah, more or less. I think it is ok as is though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
