stankiewicz commented on code in PR #36962:
URL: https://github.com/apache/beam/pull/36962#discussion_r2643926026


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -857,8 +857,13 @@ class BeamModulePlugin implements Plugin<Project> {
         netty_tcnative_boringssl_static             : 
"io.netty:netty-tcnative-boringssl-static:2.0.52.Final",
         netty_transport                             : 
"io.netty:netty-transport:$netty_version",
         netty_transport_native_epoll                : 
"io.netty:netty-transport-native-epoll:$netty_version",
-        opentelemetry_api                           : 
"io.opentelemetry:opentelemetry-api", // google_cloud_platform_libraries_bom 
sets version
+        opentelemetry_api                           : 
"io.opentelemetry:opentelemetry-api:$opentelemetry_version",
         opentelemetry_bom                           : 
"io.opentelemetry:opentelemetry-bom-alpha:$opentelemetry_version-alpha", // 
alpha required by extensions
+        opentelemetry_context                       : 
"io.opentelemetry:opentelemetry-context:$opentelemetry_version",
+        opentelemetry_gcp_auth                      : 
"io.opentelemetry.contrib:opentelemetry-gcp-auth-extension:$opentelemetry_version-alpha",

Review Comment:
   thanks, fixed versioning. 



##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValues.java:
##########
@@ -904,11 +987,14 @@ public <NewT> WindowedValueCoder<NewT> 
withValueCoder(Coder<NewT> valueCoder) {
     @Override
     public void encode(WindowedValue<T> windowedElem, OutputStream outStream)
         throws CoderException, IOException {
-      encode(windowedElem, outStream, Context.NESTED);
+      encode(windowedElem, outStream, 
org.apache.beam.sdk.coders.Coder.Context.NESTED);

Review Comment:
   done. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to