junaiddshaukat opened a new pull request, #37214:
URL: https://github.com/apache/beam/pull/37214
## Summary
Fixes #37213
Implements LRU (Least Recently Used) cache eviction for
`CachingStateProvider` to prevent unbounded memory growth in long-running
workers.
## Problem
The `CachingStateProvider` currently has unbounded cache growth, which can
lead to memory issues. There's a TODO comment indicating this needs to be
addressed:
// TODO: (Perf) Cache eviction.## Solution
- Add configurable `maxCacheSize` parameter (default: 1000 entries)
- Implement LRU eviction: remove oldest entry when cache reaches capacity
- Maintain LRU order using JavaScript Map's insertion order
- Move accessed items to end (most recently used) on cache hits
## Changes
- Modified `sdks/typescript/src/apache_beam/worker/state.ts`:
- Added `maxCacheSize` constructor parameter
- Implemented `evictIfNeeded()` method
- Implemented `touchCacheEntry()` method for LRU ordering
- Updated `getState()` to use eviction and LRU tracking
- Added `sdks/typescript/test/state_provider_test.ts`:
- Test cache hits/misses
- Test LRU eviction behavior
- Test promise-based state fetches
- Test custom maxCacheSize
## Testing
- All tests pass: `npm test` in `sdks/typescript`
- 4 new test cases added for `CachingStateProvider`
- No breaking changes (backward compatible)
## Checklist
- [x] Mention the appropriate issue in your description (`fixes #37213`)
- [ ] Update `CHANGES.md` with noteworthy changes (not applicable - internal
performance improvement)
- [ ] If this contribution is large, please file an Apache ICLA (not
applicable - small fix)
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
