Re: [PR] Support picosecond tiemstamps when writing GenericRecord and Beam Rows. [beam]

Tue, 13 Jan 2026 10:24:28 -0800 


gemini-code-assist[bot] commented on code in PR #37294:
URL: https://github.com/apache/beam/pull/37294#discussion_r2687570241


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##########
@@ -348,6 +348,9 @@ private static TableFieldSchema 
fieldDescriptorFromAvroField(org.apache.avro.Sch
             fieldDescriptorFromAvroField(
                 new Schema.Field(field.name(), elementType, field.doc(), 
field.defaultVal()));
         builder = builder.setType(elementFieldSchema.getType());
+        if (elementFieldSchema.hasTimestampPrecision()) {
+          
builder.setTimestampPrecision(elementFieldSchema.getTimestampPrecision());

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   For consistency with the surrounding code (e.g., lines 350 and 355) and the 
parallel change in `BeamRowToStorageApiProto.java`, it's better to reassign the 
builder variable. This improves code consistency and maintainability.
   
   ```suggestion
             builder = 
builder.setTimestampPrecision(elementFieldSchema.getTimestampPrecision());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to