damccorm commented on code in PR #37296:
URL: https://github.com/apache/beam/pull/37296#discussion_r2691725967
##########
sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py:
##########
@@ -309,9 +308,6 @@ def process(self, query, *unused_args, **unused_kwargs):
# e.code.value contains the numeric http status code.
service_call_metric.call(e.code.value)
raise
- except HttpError as e:
- service_call_metric.call(e)
- raise
Review Comment:
I think it is ok to leave as is if these clients shouldn't return the
exception. We can't report the error code correctly with a broader catch
anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
