NayanMathur411 opened a new pull request, #37360: URL: https://github.com/apache/beam/pull/37360
Fixes https://github.com/apache/beam/issues/35717 When using `--requirements_file`, the Python SDK downloads wheel packages to a cache directory (TEMPDIR/dataflow-requirements-cache), the stager would stage all packages in the cache directory, even those not needed by the current workflow. This caused unnecessary files to be staged and uploaded. ### Changes - Modified `_populate_requirements_cache` to download packages to a temporary directory first, then copy to cache. This allows tracking exactly which packages are needed for the current requirements file. - Updated `create_job_resources` to only stage packages returned by `_populate_requirements_cache`, rather than globbing the entire cache directory. - Renamed cache directory from `dataflow-requirements-cache` to `beam-requirements-cache` (runner-agnostic naming). - Added test `test_only_required_packages_staged_from_cache` to verify the fix. ### Example Before this fix: 1. Run workflow A with requirements.txt containing numpy, pandas → cache has numpy.whl, pandas.whl 2. Run workflow B with requirements.txt containing scipy → cache now has numpy.whl, pandas.whl, scipy.whl 3. Workflow B stages all 3 packages, even though only scipy is needed After this fix: - Workflow B only stages scipy.whl ### Testing - Existing `stager_test.py` tests pass - New test `test_only_required_packages_staged_from_cache` verifies only required packages are staged ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
