tvalentyn commented on code in PR #37331:
URL: https://github.com/apache/beam/pull/37331#discussion_r2718383362
##########
sdks/python/container/boot.go:
##########
@@ -155,6 +155,12 @@ func launchSDKProcess() error {
logger.Fatalf(ctx, "Failed to convert pipeline options: %v",
err)
}
+ pipNoBuildIsolation = false
+ if strings.Contains(options, "pip_no_build_isolation") {
Review Comment:
should we make the check more narrow (e.g. to find experiments, and check
the experiments) instead of finding substrings in the entire blob of options? I
worry this pattern might be repeated in some other context where it might cause
a collision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
