ahmedabu98 commented on code in PR #37340:
URL: https://github.com/apache/beam/pull/37340#discussion_r2718533509
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/FilterUtils.java:
##########
@@ -285,9 +287,9 @@ private static Expression convertFieldInLiteral(Operation
op, SqlBasicCall call,
checkArgument(
value instanceof SqlNodeList,
"Expected right hand side to be a list but got " + value.getClass());
- String caseInsensitiveName = ((SqlIdentifier) term).getSimple();
+ String caseInsensitiveName = getFieldName((SqlIdentifier) term);
Types.NestedField field =
schema.caseInsensitiveFindField(caseInsensitiveName);
- String name = field.name();
+ String name = schema.findColumnName(field.fieldId());
Review Comment:
Curious about this line's change. We already found the field, why do we need
to go back to the schema to find the name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
