damccorm commented on code in PR #37112:
URL: https://github.com/apache/beam/pull/37112#discussion_r2743672685
##########
sdks/python/apache_beam/utils/multi_process_shared.py:
##########
@@ -79,6 +83,10 @@ def singletonProxy_release(self):
assert self._SingletonProxy_valid
self._SingletonProxy_valid = False
+ def singletonProxy_unsafe_hard_delete(self):
+ assert self._SingletonProxy_valid
+ self._SingletonProxy_entry.unsafe_hard_delete()
Review Comment:
Do we still need this piece now that we're not passing around a proxy?
##########
sdks/python/apache_beam/utils/multi_process_shared.py:
##########
@@ -79,6 +83,10 @@ def singletonProxy_release(self):
assert self._SingletonProxy_valid
self._SingletonProxy_valid = False
+ def singletonProxy_unsafe_hard_delete(self):
+ assert self._SingletonProxy_valid
+ self._SingletonProxy_entry.unsafe_hard_delete()
Review Comment:
If we do its fine, it mostly depends on how you now want to track models in
the manager. You can leave it for now if unsure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
