gemini-code-assist[bot] commented on code in PR #37474:
URL: https://github.com/apache/beam/pull/37474#discussion_r2755360871
##########
sdks/python/apache_beam/coders/coders_test_common.py:
##########
@@ -802,7 +808,8 @@ def
test_cross_process_encoding_of_special_types_is_deterministic(
])
compat_version = {'"'+ compat_version +'"' if compat_version else None}
- typecoders.registry.update_compatibility_version = compat_version
+ pipeline_construction_options.options = PipelineOptions(
+ update_compatibility_version=compat_version)
Review Comment:
The `compat_version` variable is being reassigned to a `set` on the
preceding line (810). When this `set` is passed as
`update_compatibility_version`, it will cause a failure in
`is_compat_version_prior_to` which expects a string for version comparison.
This is because `is_compat_version_prior_to` will attempt to call `.split()` on
the set object.
Line 810 seems incorrect and should probably be removed, as `compat_version`
is already correctly set from the test parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
