gemini-code-assist[bot] commented on PR #37502: URL: https://github.com/apache/beam/pull/37502#issuecomment-3848543345
## Summary of Changes Hello @shunping, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is the second part of migrating the Java SDK's Google Cloud Storage client library. It introduces `GcsUtilV2`, a new utility class that integrates the modern `google-cloud-storage` client. The existing `GcsUtil` is enhanced to support both the legacy and new client implementations, with the choice controlled by an experimental flag. This approach enables a controlled transition to the updated GCS client, ensuring compatibility and allowing for thorough testing of the new implementation. ### Highlights * **Introduction of GcsUtilV2**: A new class `GcsUtilV2` has been added to utilize the modern `google-cloud-storage` client library for GCS operations, providing updated methods for interacting with Google Cloud Storage. * **Conditional GcsUtilV2 Usage**: The main `GcsUtil` class now conditionally initializes and delegates calls to `GcsUtilV2` based on an experimental flag (`use_gcsutil_v2`), allowing for a phased adoption and controlled rollout of the new client. * **API Modernization**: Existing `getObject` methods in `GcsUtil` are deprecated in favor of a new `getBlob` method, aligning the API with the new client library's `Blob` object model for GCS objects. * **Parameterized Integration Tests**: Integration tests (`GcsUtilIT`) have been refactored to run parameterized tests, verifying functionality against both the legacy (`GcsUtilV1`) and the new (`GcsUtilV2`) GCS utility implementations to ensure compatibility and correctness. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java** * Added `com.google.cloud.storage.Blob` import. * Introduced `delegateV2` field for `GcsUtilV2`. * Modified constructor to accept `shouldUseV2` parameter, enabling conditional `GcsUtilV2` instantiation via an experimental flag. * Updated `fileSize` to delegate to `delegateV2` if active. * Deprecated `getObject` methods, recommending `getBlob(GcsPath)`. * Added `getBlob(GcsPath)` method, delegating to `delegateV2` when enabled. * **sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV2.java** * New file: Implements GCS operations using the `google-cloud-storage` client library. * Provides `getBlob` and `fileSize` methods by interacting with `com.google.cloud.storage.Storage`. * Initializes `Storage` client using `StorageOptions` and project ID from `PipelineOptions`. * **sdks/java/extensions/google-cloud-platform-core/src/test/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilIT.java** * Converted to a parameterized JUnit test (`@RunWith(Parameterized.class)`). * Tests now run for both "use_gcsutil_v1" and "use_gcsutil_v2" experimental flags. * `testFileSize` and `testGetObjectOrGetBlob` methods were updated to use the appropriate GCS utility version based on the active experiment. * Several previous tests (`testRewriteMultiPart`, `testWriteAndReadGcsWithGrpc`) were commented out. </details> <details> <summary><b>Activity</b></summary> * No specific activity (comments, reviews, etc.) was provided in the context for this pull request. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
