gemini-code-assist[bot] commented on code in PR #37503:
URL: https://github.com/apache/beam/pull/37503#discussion_r2765600851
##########
sdks/python/tox.ini:
##########
@@ -343,26 +343,22 @@ extras = test
commands =
bash {toxinidir}/scripts/pytest_validates_runner.sh {envname}
{toxinidir}/apache_beam/runners/portability/prism_runner_test.py {posargs}
-[testenv:py{310,311}-pyarrow-{3,9,10,11,12,13,14,15,16,17,18}]
+[testenv:py{310,311}-pyarrow-{6,15,16,17,18,19,20,21,22,23}]
deps =
# As a courtesy to users, test against the oldest allowed version of Pyarrow.
# We'd have to increase the pyarrow lower bound when Python 3.9 is
deprecated.
# Since Pandas 2 requires pyarrow>=7, downgrade pandas for this test.
- 3: pyarrow>=3,<4
- 3: pandas<2
- 3: numpy>=1.14.3,<1.27.0
+ 6: pyarrow>=6,<7
Review Comment:
The test environment for `pyarrow` version 6 is missing a version constraint
for the `pandas` library. According to the comment on line 350, `pandas>=2`
requires `pyarrow>=7`. Since this test environment uses `pyarrow>=6,<7`, not
constraining the `pandas` version could lead to the installation of an
incompatible version (e.g., pandas 2.x), which would likely cause test
failures. It's advisable to add a constraint to use `pandas<2` for this
specific test case.
```
6: pyarrow>=6,<7
6: pandas<2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
