gemini-code-assist[bot] commented on PR #37592: URL: https://github.com/apache/beam/pull/37592#issuecomment-3897648584
## Summary of Changes Hello @shunping, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request continues the migration of the Java SDK's GCS client library, focusing on core file manipulation operations. It introduces new V2 methods for copying, renaming, and removing files, providing more granular control over behavior in scenarios involving missing source files or existing destination files. This change aims to improve the robustness and flexibility of GCS file operations within the SDK by leveraging the updated client library capabilities. ### Highlights * **GCS Client Library Migration**: Introduced new `copyV2`, `renameV2`, and `removeV2` methods in `GcsUtil` to leverage the `GcsUtilV2` implementation for file operations. * **Enhanced File Operations in GcsUtilV2**: Implemented robust `copy`, `move`, and `remove` operations in `GcsUtilV2` using the Google Cloud Storage client library, supporting various `MissingStrategy` and `OverwriteStrategy` options for finer control over behavior. * **Comprehensive Integration Tests**: Added extensive integration tests for `copy`, `remove`, and `rename` operations in `GcsUtilParameterizedIT` to validate both V1 and V2 behaviors, including different strategies and error handling. * **GcsPath Wildcard Handling**: Enhanced `GcsPathTest` with additional test cases for wildcard paths, specifically addressing root-level wildcards. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java** * Added imports for `Set`, `StorageObjectOrIOException`, `MissingStrategy`, `OverwriteStrategy`, `StandardMoveOptions`, and `Sets`. * Introduced `copyV2` and `copy` methods that accept `GcsPath` and `OverwriteStrategy`. * Introduced `renameV2` and `rename` methods that accept `GcsPath`, `MissingStrategy`, and `OverwriteStrategy`. * Introduced `removeV2` and `remove` methods that accept `GcsPath` and `MissingStrategy`. * These new methods delegate their functionality to `GcsUtilV2`. * **sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV2.java** * Added `checkArgument` import. * Added imports for `BlobId`, `BlobInfo`, `CopyWriter`, and `CopyRequest`. * Defined `MEGABYTES_COPIED_PER_CHUNK` constant to control copy chunk size. * Updated `translateStorageException` to handle `FileNotFoundException` for 404 errors. * Introduced `MissingStrategy` and `OverwriteStrategy` enums to define behavior for file operations. * Implemented the `remove` method using batch deletion with `MissingStrategy`. * Implemented `rewriteHelper` to encapsulate common logic for copy and move operations, incorporating `MissingStrategy` and `OverwriteStrategy`. * Implemented the `copy` method by leveraging the `rewriteHelper`. * Implemented the `move` method by leveraging the `rewriteHelper`. * **sdks/java/extensions/google-cloud-platform-core/src/test/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilParameterizedIT.java** * Added imports for `MissingStrategy`, `OverwriteStrategy`, and `MoveOptions`. * Introduced `createTestBucketHelper` and `tearDownTestBucketHelper` for managing test bucket setup and cleanup. * Added `testCopy` method with extensive tests for both V1 and V2 `copy` operations, covering various `OverwriteStrategy` scenarios and expected error handling. * Added `testRemove` method with comprehensive tests for both V1 and V2 `remove` operations, including `MissingStrategy` scenarios and error handling. * Added `testRename` method with detailed tests for both V1 and V2 `rename` operations, covering `MoveOptions` and error handling, and highlighting a V1 bug. * Added `assertExists` and `assertNotExists` helper methods for asserting the presence or absence of GCS paths. * **sdks/java/extensions/google-cloud-platform-core/src/test/java/org/apache/beam/sdk/extensions/gcp/util/gcsfs/GcsPathTest.java** * Updated `testIsWildcard` to include a test case for 'gs://bucket/*' wildcard pattern. * Updated `testGetNonWildcardPrefix` to include a test case for 'gs://bucket/*' prefix extraction. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
