tarun-google commented on code in PR #37581: URL: https://github.com/apache/beam/pull/37581#discussion_r2805756273
########## sdks/python/apache_beam/runners/dataflow/internal/clients/dataflow/dataflow_v1b3_client.py: ########## @@ -12,41 +15,26 @@ class DataflowV1b3(base_api.BaseApiClient): MTLS_BASE_URL = 'https://dataflow.mtls.googleapis.com/' _PACKAGE = 'dataflow' - _SCOPES = [ - 'https://www.googleapis.com/auth/cloud-platform', - 'https://www.googleapis.com/auth/compute' - ] + _SCOPES = ['https://www.googleapis.com/auth/cloud-platform', 'https://www.googleapis.com/auth/compute'] _VERSION = 'v1b3' - _CLIENT_ID = '1042881264118.apps.googleusercontent.com' - _CLIENT_SECRET = 'x_Tw5K8nnjoRAqULM9PFAC2b' + _CLIENT_ID = 'CLIENT_ID' Review Comment: I do not think storing the secret and id here is required. when we run from local it gets gcloud creds. If you think other users might need it we can manually fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
