junaiddshaukat opened a new pull request, #37607:
URL: https://github.com/apache/beam/pull/37607
Resolves #37606
## Summary
`KafkaCommitOffset.CommitOffsetDoFn.commitSync()` currently catches all
exceptions and silently skips them, meaning transient failures (network
timeouts, temporary broker issues) cause offsets to never be committed.
This can lead to duplicate processing after a restart.
This PR addresses the existing `// TODO: consider retrying.` by adding
exponential backoff retry (3 retries: 500ms, 1s, 2s) for Kafka's
`RetriableException` subclasses, while preserving warn-and-skip for
non-retriable exceptions. Retry count is consistent with Beam's existing
Kafka producer default (`RETRIES_CONFIG = 3`).
## Changes
**`KafkaCommitOffset.java`**
- Retry up to 3 times with exponential backoff (500ms, 1s, 2s) when
`commitSync()` throws a `RetriableException` (e.g., `TimeoutException`)
- Non-retriable exceptions still log a warning and skip (preserving
existing behavior)
- Thread interruption during backoff is handled gracefully
**`KafkaCommitOffsetTest.java`**
- Added `testCommitOffsetRetriableErrorSucceedsAfterRetry`: verifies
that transient failures are retried and the offset is committed on
the successful attempt
- Added `KafkaRetriableMockConsumer`: mock that throws
`RetriableCommitFailedException` N times before succeeding
## Test plan
- [x] Existing `KafkaCommitOffsetTest` tests pass
- [x] New retry test verifies commit succeeds after transient failures
- [x] Existing error test confirms non-retriable exceptions still
warn-and-skip
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [X] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
