gemini-code-assist[bot] commented on PR #37621:
URL: https://github.com/apache/beam/pull/37621#issuecomment-3915299307
## Summary of Changes
Hello @mutianf, I'm Gemini Code Assist[^1]! I'm currently reviewing this
pull request and will post my feedback shortly. In the meantime, here's a
summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Bigtable reader by introducing a new
`withColumns` option. This provides a convenient and templatable way to specify
column filters for data retrieval, allowing users to define column families and
qualifiers using a string-based format. This is especially beneficial in
contexts like templates where direct `RowFilter` objects cannot be easily
passed.
### Highlights
* **New `withColumns` Option**: A `withColumns` method was added to
`BigtableIO.Read`, allowing users to specify column filters using a flexible
string format, which is particularly useful for templated pipelines.
* **Flexible Column Specification**: The new option supports a string format
for defining column filters, including wildcards (`*`), explicit inclusions
(`{q1|q2}`), and exclusions (`!{q1|q2}`) of qualifiers, with support for
escaping special characters like comma and pipe.
* **Chained Filtering Logic**: The column filter generated from
`withColumns` is automatically combined (chained) with any existing `RowFilter`
specified via `withRowFilter`, enabling complex filtering scenarios.
* **Internal Parsing and `RowFilter` Generation**: New internal methods
(`parseColumns`, `addExcludeQualifiers`, `addIncludeQualifiers`,
`cleanupQualifier`) were implemented to convert the string-based column
specification into a Bigtable `RowFilter` object.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help
**Gemini Code Assist** learn from your team's feedback. This makes future code
reviews more consistent and personalized to your project's style. **Click
[here](https://codeassist.google/code-review/login) to enable Memory in your
admin console.**
<details>
<summary><b>Changelog</b></summary>
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java**
* Added `withColumns` method to `BigtableIO.Read` for string-based
column filtering.
* Introduced `COLUMN_REGEX` and `QUALIFIER_REGEX` patterns for parsing
column specifications.
* Implemented `parseColumns`, `addExcludeQualifiers`,
`addIncludeQualifiers`, and `cleanupQualifier` methods to construct `RowFilter`
from column strings.
* Modified `getRowFilter` to combine the new column filter with any
existing row filter.
* Added necessary imports for `ColumnRange`, `TreeSet`, `Matcher`,
`Pattern`, `Splitter`, and `ByteStringComparator`.
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadOptions.java**
* Added `getColumns()` and `setColumns()` abstract methods to
`BigtableReadOptions` and its `Builder` to store the column specification
string.
* Updated `populateDisplayData` to include the new `columns` option in
display data.
* Added validation for the `columns` option in the `validate` method.
*
**sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java**
* Added `testParseColumnFilter` to verify the parsing logic and
`RowFilter` generation for various column string formats, including combined
row and column filters.
* Imported `ColumnRange` for testing column range filters.
* Updated an existing test case to pass `RowFilter` directly to
`withRowFilter`.
</details>
<details>
<summary><b>Activity</b></summary>
* The pull request description includes a standard checklist for
contributions, indicating general guidelines for the author.
* Automated CI status badges are present, showing the build health on the
master branch for Python, Java, and Go tests.
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation
page](https://developers.google.com/gemini-code-assist/docs/review-github-code),
here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment
using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a
summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull
request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current
pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged,
both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository
maintainers can create a configuration file and/or provide a custom code review
style guide (such as PEP-8 for Python) by creating and adding files to a
`.gemini/` folder in the base of the repository. Detailed instructions can be
found
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances
where its feedback is incorrect or counter productive. You can react with
:thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're
interested in giving your feedback about your experience with Gemini Code
Assist for Github and other Google products, sign up
[here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code
reviews directly in the IDE at no cost with the [Gemini Code Assist IDE
Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy),
[Generative AI Prohibited Use
Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of
Service](https://policies.google.com/terms), and learn how to configure Gemini
Code Assist in GitHub
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
Gemini can make mistakes, so double check it and [use code with
caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
