Eliaaazzz commented on PR #37355: URL: https://github.com/apache/beam/pull/37355#issuecomment-3917832141
> This seems good to me. Considering your explanation... I wonder if always generated a "raw invoker" is a fine way to go anyhow. Because this is intended as just automatically generated glue code, and it will always execute the same anyhow... > > Since this touches every single pipeline, I think we'll want to run a lot of testing. There are bunch of "trigger files" in the `.github/trigger_files` directory where if you touch them it will run additional suites. I'm not sure exactly which are best, but hitting some of the `ValidatesRunner` and `PostCommit` tests will run a number of distributed tests that may be worthwhile. Thanks Kenn! Since this touches every pipeline, I’ll trigger additional ValidatesRunner/PostCommit suites via .github/trigger_files and report the results here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
