gemini-code-assist[bot] commented on PR #37648: URL: https://github.com/apache/beam/pull/37648#issuecomment-3927774451
## Summary of Changes Hello @stankiewicz, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the KafkaIO Exactly-Once Semantics (EOS) sink by introducing configurable triggering mechanisms. The primary goal is to optimize performance by allowing the sink to batch multiple messages or wait for a specified duration before committing transactions, addressing the inefficiency of single-element transactions. This change provides users with greater control over the trade-off between latency and throughput for their Kafka writes. ### Highlights * **Configurable EOS Triggering**: Introduced new configuration options, `numElements` and `timeout`, to control the triggering of transactions in the KafkaIO Exactly-Once Semantics (EOS) sink. This allows users to batch multiple messages before committing, improving performance for scenarios where single-element transactions are slow. * **Windowing Logic Update**: Modified the internal windowing and triggering mechanism within `KafkaExactlyOnceSink` to leverage the new `numElements` and `timeout` parameters. The triggering now uses `AfterFirst` of `AfterPane.elementCountAtLeast` or `AfterProcessingTime.pastFirstElementInPane().plusDelayOf`. * **API Extension**: Extended the `KafkaIO.Write` and `KafkaIO.WriteRecords` classes with a new `withEOSTriggerConfig` method, providing a fluent API for users to specify their desired batching behavior for EOS sinks. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java** * Added imports for `AfterFirst`, `AfterProcessingTime`, and `Duration`. * Extracted `numElements` and `timeout` from the sink specification for use in windowing. * Updated the `Window` transformation's triggering logic to use `Repeatedly.forever(AfterFirst.of(AfterPane.elementCountAtLeast(numElements), AfterProcessingTime.pastFirstElementInPane().plusDelayOf(timeout)))` for both initial input and sequenced elements. * **sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java** * Set default values for `numElements` (100) and `timeout` (1 second) in the `WriteRecords` builder when EOS is enabled. * Added abstract getter methods `getNumElements()` and `getTimeout()` to the `WriteRecords` class. * Added abstract builder methods `setNumElements()` and `setTimeout()` to `WriteRecords.Builder`. * Introduced a new public method `withEOSTriggerConfig(int numElements, Duration timeout)` to `WriteRecords` for configuring the EOS trigger. * Added a corresponding `withEOSTriggerConfig(int numElements, Duration timeout)` method to `KafkaIO.Write` for configuring the EOS trigger via the top-level API. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
