claudevdm commented on code in PR #37651:
URL: https://github.com/apache/beam/pull/37651#discussion_r2829488216
##########
sdks/python/apache_beam/ml/rag/enrichment/bigquery_vector_search.py:
##########
@@ -241,7 +241,7 @@ def format_query(self, items: List[EmbeddableItem]) -> str:
ARRAY_AGG(
STRUCT({"distance, " if self.include_distance else ""}\
{base_columns_str})
- ) as embeddable_items
+ ) as chunks
Review Comment:
This is necessary for this field is carried forward to the enrichment data.
There will be an error if the "chunks" was accessed in the enrichment transform
and we change this
https://github.com/apache/beam/blob/e41b9b6ba6965e7c5741b55730e593f58a37051b/sdks/python/apache_beam/ml/rag/enrichment/bigquery_vector_search_it_test.py#L227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
