chandrakiranbolla1 opened a new pull request, #37654: URL: https://github.com/apache/beam/pull/37654
Addresses #18719 ### What happened Currently, `checkNotNull` in the `sdks/java/core/options` package throws a `NullPointerException` (implying a bug in the code), even when validating user-supplied arguments. ### What was done Replaced Guava's `checkNotNull` with Beam's [checkArgumentNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:150:2-164:3) (throws `IllegalArgumentException`) for argument validation and [checkStateNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:546:2-563:3) (throws `IllegalStateException`) for internal state validation. Files modified: - [SdkHarnessOptions.java](cci:7://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java:0:0-0:0): [checkStateNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:546:2-563:3) for return value check - [PipelineOptionsFactory.java](cci:7://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:0:0-0:0): [checkArgumentNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:150:2-164:3) for argument check - [ValueProvider.java](cci:7://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ValueProvider.java:0:0-0:0): 3x [checkArgumentNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:150:2-164:3) + 2x [checkStateNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:546:2-563:3) - [ValueProviders.java](cci:7://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ValueProviders.java:0:0-0:0): [checkStateNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:546:2-563:3) for parsed result check - [PipelineOptionsValidator.java](cci:7://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsValidator.java:0:0-0:0): 2x [checkArgumentNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:150:2-164:3) for argument checks - [ProxyInvocationHandler.java](cci:7://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ProxyInvocationHandler.java:0:0-0:0): [checkArgumentNotNull](cci:1://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/util/Preconditions.java:150:2-164:3) for argument check - [MetricNameFilter.java](cci:7://file:///Users/naganjali/IdeaProjects/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricNameFilter.java:0:0-0:0): cleanup commented-out import ### Testing Done - Ran `./gradlew -p sdks/java/core compileJava` successfully. - Validated existing unit tests with `./gradlew :sdks:java:core:test` on JDK 11. No new tests are needed since the behavior remains the same (just throwing preferred exception types). ### ------------------------------------------------------------------------- ----------------------------------------------------------------------------- - [x] Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...` - [x] Consider adding unit PR tests and UI PR tests - [x] If this contribution is large, please file an Apache Individual Contributor License Agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
