gemini-code-assist[bot] commented on PR #37663: URL: https://github.com/apache/beam/pull/37663#issuecomment-3936290877
## Summary of Changes Hello @kennknowles, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the PR bot's ability to manage reviewer assignments and pings. It addresses previous shortcomings where the bot would incorrectly ping active reviews or fail to recognize reviewers assigned through GitHub's native UI. The changes ensure a more intelligent and less intrusive review process by integrating GitHub's reviewer assignment mechanisms more deeply into the bot's operational logic. ### Highlights * **Improved Review Activity Detection**: The PR bot now correctly identifies active reviews by checking individual review comments, preventing unnecessary pings when a review is already underway. * **Unified Reviewer Assignment Logic**: GitHub UI review assignments are now treated equivalently to 'R:' comments, ensuring the bot's logic for assigning and pinging reviewers is consistent across both methods. * **Enhanced Committer Assignment Logic**: The bot now checks if any GitHub-assigned reviewer is a committer, influencing whether it needs to assign an additional committer. * **Explicit Handling for Review Requests**: The bot now explicitly processes the 'review_requested' GitHub action, ensuring timely updates to reviewer assignments. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **scripts/ci/pr-bot/findPrsNeedingAttention.ts** * Corrected `isSlowReview` function to check individual review comment authors, preventing false positives for active reviews. * Extended `reviewersToExclude` in `assignToNewReviewers` to include users explicitly requested as reviewers via GitHub's UI. * Modified `processPull` to include GitHub-requested reviewers when constructing the list of reviewers to ping for slow reviews. * **scripts/ci/pr-bot/processNewPrs.ts** * Added `isAnyGithubReviewerCommitter` function to determine if any GitHub-requested reviewer is a committer. * Modified `processPull` to consider both bot-assigned and GitHub-requested reviewers when checking if reviewers are already assigned. * Enhanced `processPull` to attempt to derive a label for GitHub-assigned reviewers if not found in the bot's state, and updated committer check logic to include GitHub-assigned committers. * **scripts/ci/pr-bot/processPrUpdate.ts** * Updated `areReviewersAssigned` to fetch PR details and check for `pull.requested_reviewers` in addition to bot-assigned reviewers. * Added a new `else if` condition to `processPrUpdate` to explicitly handle the `review_requested` GitHub action, triggering `setNextActionReviewers`. </details> <details> <summary><b>Activity</b></summary> * No human activity (comments, reviews, or progress updates) was detected on this pull request. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
