gemini-code-assist[bot] commented on PR #37749: URL: https://github.com/apache/beam/pull/37749#issuecomment-3991084611
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the error handling mechanism within the Dataflow Java Streaming worker. Previously, `OutOfMemoryError`s were caught and potentially led to local retries, which could leave workers in an unstable state. The changes ensure that `OutOfMemoryError`s are now propagated, leading to JVM termination and a clean restart of the worker, thereby improving the overall stability and reliability of the streaming pipeline. The failure processing logic has also been made more robust and explicit. ### Highlights * **OutOfMemoryError Propagation**: OutOfMemoryError's are now explicitly rethrown in `StreamingWorkScheduler` to ensure JVM termination, preventing workers from entering a broken state due to memory exhaustion. * **Refactored Failure Handling**: The `WorkFailureProcessor` has been refactored to use a new `RetryEvaluation` enum, allowing for clearer distinction between work items that should not be retried, should be retried locally, or should cause a rethrow. * **Improved Error Management**: The system now explicitly distinguishes between different failure outcomes, ensuring that critical errors like OOM lead to immediate worker restart rather than potentially endless retries, enhancing pipeline stability. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java** * Wrapped the `workFailureProcessor.logAndProcessFailure` call in a `try-catch` block to specifically rethrow `OutOfMemoryError`s and wrap other `Throwable`s in `RuntimeException`. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/failures/WorkFailureProcessor.java** * Modified `logAndProcessFailure` to throw `Throwable` and use a `switch` statement based on the new `RetryEvaluation` enum. * Introduced a `RetryEvaluation` enum (`DO_NOT_RETRY`, `RETRY_LOCALLY`, `RETHROW_THROWABLE`) to explicitly define failure handling outcomes. * Renamed `shouldRetryLocally` to `evaluateRetry` and updated its return type to `RetryEvaluation`, adding logic to return `RETHROW_THROWABLE` for `OutOfMemoryError`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/failures/WorkFailureProcessorTest.java** * Updated several test methods to declare `throws Throwable` in their signatures. * Modified the `logAndProcessFailure_doesNotRetryOOM` test to use `assertThrows(OutOfMemoryError.class, ...)` to verify that OOM is rethrown. </details> <details> <summary><b>Activity</b></summary> * The pull request was created by scwhittle with an initial description outlining the intent to propagate `OutOfMemoryError`s to prevent broken worker states. * The description includes a standard contribution checklist and links to CI status, indicating the initial setup for review and automated checks. * No specific human review comments or further activity beyond the initial submission are available in the provided context. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
