gemini-code-assist[bot] commented on PR #37770:
URL: https://github.com/apache/beam/pull/37770#issuecomment-3999441324
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request
and will post my feedback shortly. In the meantime, here's a summary to help
you and other reviewers quickly get up to speed!
This pull request significantly enhances the code quality by activating the
'UnusedVariable' ErrorProne check. The changes primarily involve systematically
addressing the warnings generated by this check, either by explicitly marking
intentionally unused parameters and fields with `@SuppressWarnings("unused")`
or by removing variables and imports that serve no purpose. This effort
streamlines the code, reduces potential confusion, and ensures better adherence
to coding standards.
### Highlights
* **ErrorProne UnusedVariable Check Enabled**: The 'UnusedVariable'
ErrorProne check has been enabled across the codebase by removing it from the
list of suppressed checks in the Beam Gradle plugin configuration.
* **Suppression of Unused Parameters**: Numerous instances of
`@SuppressWarnings("unused")` have been added to method parameters,
particularly in `DoFn` implementations and test classes, where parameters are
required by method signatures but not explicitly used within the method body.
* **Removal of Truly Unused Variables and Imports**: Several truly unused
local variables, fields, and import statements have been identified and
removed, contributing to a cleaner and more efficient codebase.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help
**Gemini Code Assist** learn from your team's feedback. This makes future code
reviews more consistent and personalized to your project's style. **Click
[here](https://codeassist.google/code-review/login) to enable Memory in your
admin console.**
<details>
<summary><b>Changelog</b></summary>
* **buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy**
* Removed 'UnusedVariable' from the list of ErrorProne suppressions,
enabling the check.
*
**runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java**
* Annotated 'element' parameters with '@SuppressWarnings("unused")' in
'getInitialRestriction' methods.
*
**runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java**
* Annotated 'elem' and 'element' parameters with
'@SuppressWarnings("unused")' in 'getInitialRestriction' methods.
* Annotated 'ProcessContext c' and 'RestrictionTracker' parameters with
'@SuppressWarnings("unused")' in 'process' methods.
*
**runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java**
* Annotated 'CommittedBundle<?> bundle' parameter with
'@SuppressWarnings("unused")' in 'commitLogical' method.
*
**runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java**
* Annotated 'ProcessContext c' parameters with
'@SuppressWarnings("unused")' in 'processElement' methods.
*
**runners/direct-java/src/test/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactoryTest.java**
* Annotated 'readerAdvancedCount' static field with
'@SuppressWarnings("unused")'.
*
**runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java**
* Removed unused import for 'StateBackend'.
* Removed unused local variable 'stateBackend'.
*
**runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java**
* Annotated 'ProcessContext context' parameters with
'@SuppressWarnings("unused")' in 'doNothing' methods.
*
**runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java**
* Annotated 'pos' fields with '@SuppressWarnings("unused")' in
'UnboundedReader' and 'Checkpoint' classes.
*
**runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java**
* Annotated 'ProcessContext c' and 'RestrictionTracker' parameters with
'@SuppressWarnings("unused")' in 'process' method.
* Annotated 'element' parameter with '@SuppressWarnings("unused")' in
'getInitialRange' method.
*
**runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java**
* Annotated 'name' and 'content' fields with
'@SuppressWarnings("unused")' in 'Page' class.
*
**runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java**
* Annotated 'ProcessContext processContext' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java**
* Annotated 'array' field with '@SuppressWarnings("unused")' in
'SourceWithLargeObject' class.
*
**runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java**
* Annotated 'String[] args' parameters with
'@SuppressWarnings("unused")' in 'main' methods.
*
**runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java**
* Annotated 'ProcessContext context' parameter with
'@SuppressWarnings("unused")' in 'doNothing' method.
*
**sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java**
* Removed 'outputSchema' parameter from 'SelectDoFn' constructor and its
usages.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java**
* Annotated 'ProcessContext c' parameters with
'@SuppressWarnings("unused")' in 'processElement' methods.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java**
* Annotated 'PipelineOptions options' parameter with
'@SuppressWarnings("unused")' in 'fromOptions' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java**
* Annotated 'options' field with '@SuppressWarnings("unused")' in
'CapturesOptions' class.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java**
* Annotated 'name' field with '@SuppressWarnings("unused")' in
'TestCase' class.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java**
* Annotated 'BoundedWindow w' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java**
* Annotated 'DisplayData.ItemSpec<?> spec' parameter with
'@SuppressWarnings("unused")' in 'HoldsItemSpecReference' constructor.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java**
* Annotated 'ProcessContext context' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java**
* Annotated 'ProcessContext context' and 'RestrictionTracker' parameters
with '@SuppressWarnings("unused")' in 'processElement' methods.
* Annotated 'element' parameters with '@SuppressWarnings("unused")' in
'getInitialRestriction' methods.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java**
* Annotated 'ProcessContext context' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java**
* Annotated 'ProcessContext context' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java**
* Annotated 'ProcessContext context' and 'BoundedWindow window'
parameters with '@SuppressWarnings("unused")' in 'proc' method.
* Annotated 'element' parameter with '@SuppressWarnings("unused")' in
'restriction' method.
* Annotated 'restriction' parameter with '@SuppressWarnings("unused")'
in 'newTracker' method.
* Annotated 'BundleFinalizer' parameters with
'@SuppressWarnings("unused")' in 'startBundle', 'processElement', and
'finishBundle' methods.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java**
* Annotated 'ProcessContext context' and 'RestrictionTracker' parameters
with '@SuppressWarnings("unused")' in 'processElement' methods.
* Annotated 'element' parameters with '@SuppressWarnings("unused")' in
'getInitialRestriction' methods.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java**
* Annotated 'Row row' and 'OutputReceiver<Row> outputReceiver'
parameters with '@SuppressWarnings("unused")' in 'processElement' methods.
* Annotated 'ProcessContext c' parameters with
'@SuppressWarnings("unused")' in 'processElement' methods.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java**
* Annotated 'Row row' and 'OutputReceiver<Row> outputReceiver'
parameters with '@SuppressWarnings("unused")' in 'processElement' methods.
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java**
* Annotated 'ProcessContext ctxt' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java**
* Annotated 'PipelineOptions opts' parameter with
'@SuppressWarnings("unused")' in 'fromOptions' method.
*
**sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java**
* Annotated 'genericRecord' and 'withCustomSchema' fields with
'@SuppressWarnings("unused")'.
*
**sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java**
* Removed 'isStart' field from 'State' class and its constructor.
* Updated 'loadStates' method to no longer use the 'isStart' flag.
*
**sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java**
* Annotated 'ProcessContext context' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java**
* Annotated 'ProcessContext c' parameters with
'@SuppressWarnings("unused")' in 'processElement' methods.
*
**sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java**
* Annotated 'ProcessContext context' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java**
* Removed unused 'specifiedParallelism' field and its assignment in
'CreateKeysFn' constructor.
*
**sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java**
* Annotated 'StartBundleContext context' parameter with
'@SuppressWarnings("unused")' in 'startBundle' method.
*
**sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java**
* Removed unused 'schema' field from 'CreateKVJsonString' and updated
its constructor calls.
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java**
* Removed 'BoundedWindow window' field from 'PendingJobData' class and
its constructor.
* Annotated 'BoundedWindow window' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java**
* Annotated 'StartBundleContext c' parameter with
'@SuppressWarnings("unused")' in 'startBundle' method.
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java**
* Annotated 'FinishBundleContext c' parameter with
'@SuppressWarnings("unused")' in 'finish' method.
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java**
* Annotated 'FinishBundleContext c' parameter with
'@SuppressWarnings("unused")' in 'finish' method.
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java**
* Removed unused 'fullPartitionMetadataDatabaseId' variable declaration.
*
**sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java**
* Annotated 'FinishBundleContext c' parameter with
'@SuppressWarnings("unused")' in 'finish' method.
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java**
* Annotated 'TimestampPrecision precision' parameter with
'@SuppressWarnings("unused")' in 'createAvroTsResponse' method.
*
**sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java**
* Removed unused 'Timestamp now' variable declaration.
*
**sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java**
* Annotated 'StartBundleContext c' parameters with
'@SuppressWarnings("unused")' in 'startBundle' methods.
*
**sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java**
* Annotated 'ProcessContext context' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'process' method.
*
**sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java**
* Annotated 'Duration periodLength' parameter with
'@SuppressWarnings("unused")' in 'GenerateRecordsStream' constructor.
*
**sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java**
* Annotated 'rows' variable with '@SuppressWarnings("unused")'.
* **sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java**
* Annotated 'StartBundleContext context' parameter with
'@SuppressWarnings("unused")' in 'startBundle' method.
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
*
**sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java**
* Removed unused 'LOG' field.
*
**sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java**
* Removed unused 'LOG' field.
*
**sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java**
* Annotated 'ParameterT element' parameters with
'@SuppressWarnings("unused")' in 'getInitialRange' and 'splitRange' methods.
*
**sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java**
* Removed unused 'parameters' field from 'MockSuccessHandler' and
updated 'createClient' method.
* Annotated 'TestParameters parameters' parameters with
'@SuppressWarnings("unused")' in 'createClient' methods.
* Annotated 'String required' parameter with
'@SuppressWarnings("unused")' in 'MockNoDefaultConstructorHandler' constructor.
*
**sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java**
* Removed unused 'ENFORCEMENT_KEY' field.
*
**sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java**
* Annotated 'ProcessContext c' parameter with
'@SuppressWarnings("unused")' in 'processElement' method.
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation
page](https://developers.google.com/gemini-code-assist/docs/review-github-code),
here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment
using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a
summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull
request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current
pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged,
both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository
maintainers can create a configuration file and/or provide a custom code review
style guide (such as PEP-8 for Python) by creating and adding files to a
`.gemini/` folder in the base of the repository. Detailed instructions can be
found
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances
where its feedback is incorrect or counter productive. You can react with
:thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're
interested in giving your feedback about your experience with Gemini Code
Assist for Github and other Google products, sign up
[here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code
reviews directly in the IDE at no cost with the [Gemini Code Assist IDE
Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy),
[Generative AI Prohibited Use
Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of
Service](https://policies.google.com/terms), and learn how to configure Gemini
Code Assist in GitHub
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
Gemini can make mistakes, so double check it and [use code with
caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
