gemini-code-assist[bot] commented on PR #37776: URL: https://github.com/apache/beam/pull/37776#issuecomment-4004318474
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and maintainability of Python SDK tests, particularly those involving Vertex AI. It standardizes how Vertex AI dependencies are handled within tests, ensuring more reliable execution. Additionally, it updates the dependency matrix for PyArrow and Transformers in the build system, aligning with current testing requirements and improving the overall test suite's efficiency. ### Highlights * **Vertex AI Test Refactoring**: Refactored Vertex AI related tests across multiple files to use `pytest.importorskip` for dependency checks and applied `@pytest.mark.vertex_ai_postcommit` at the class level for better organization and consistency, replacing `unittest.skipIf`. * **PyArrow Dependency Updates**: Updated the `build.gradle` configuration for Python 3.10 to remove older PyArrow versions (9-14) and include newer ones (6, 19-23) for postcommit testing. * **Transformers Dependency Configuration**: Adjusted the `tox.ini` file to streamline `transformers` test environments, removing specific version `448` and simplifying `extras` installation, along with adding `pip_pre = False`. * **File Renaming**: Renamed `sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py` to `sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_it_test.py` to better reflect its nature as an integration test. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/python/apache_beam/ml/inference/vertex_ai_inference_it_test.py** * Added `pytest.importorskip` for `vertexai` to ensure dependencies are met. * Moved `@pytest.mark.vertex_ai_postcommit` from method to class level for broader test coverage. * Removed redundant `@pytest.mark.vertex_ai_postcommit` from a specific test method. * **sdks/python/apache_beam/ml/rag/embeddings/vertex_ai_test.py** * Imported `pytest` for test framework functionalities. * Replaced `VERTEX_AI_AVAILABLE` flag and `unittest.skipIf` with `pytest.importorskip` and `pytest.mark.vertex_ai_postcommit` for test classes. * Set `VertexAIImageEmbeddings`, `VertexAITextEmbeddings`, and `_create_image_adapter` to `None` on `ImportError` to handle missing dependencies gracefully. * **sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_it_test.py** * Renamed file from `vertex_ai_test.py` to `vertex_ai_it_test.py`. * Imported `pytest` for test framework functionalities. * Added `pytest.importorskip` for `vertexai` to ensure dependencies are met. * Replaced `unittest.skipIf` with `pytest.mark.vertex_ai_postcommit` for test classes. * **sdks/python/test-suites/tox/py310/build.gradle** * Removed `py310-pyarrow-9` through `py310-pyarrow-14` from postcommit dependencies. * Added `py310-pyarrow-6` to postcommit dependencies. * Added `py310-pyarrow-19` through `py310-pyarrow-23` to postcommit dependencies. * Removed `py310-transformers-448` from postcommit dependencies. * **sdks/python/tox.ini** * Updated `testenv` definition for `transformers` to remove `448` from the list of versions. * Removed `gcp,ml_test` from `extras` for `transformers` test environments. * Added `pip_pre = False` to the test environment configuration. * Removed `455: DEPS` entry from the `setenv` section. </details> <details> <summary><b>Activity</b></summary> * The pull request description is a template and does not contain specific human activity or comments regarding the changes. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
