gemini-code-assist[bot] commented on PR #37780: URL: https://github.com/apache/beam/pull/37780#issuecomment-4006596466
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the dependency management for the HCatalog module, specifically addressing how `hive-exec` and its transitive dependencies are handled during compilation and testing. The changes aim to resolve dependency conflicts, particularly with `joda-time`, by differentiating between compile-time and test-time requirements. This ensures a cleaner build environment while providing the necessary full dependencies for robust test execution, especially for embedded Hive setups. ### Highlights * **Dependency Management for Hive-exec**: The `hive-exec` dependency for compilation has been updated to use the `core` classifier, specifically `org.apache.hive:hive-exec:core`, to avoid bringing in shaded dependencies like `joda-time` during compilation. * **Test Dependency Configuration**: The full, shaded `hive-exec` JAR is now explicitly used for tests, ensuring that embedded cluster setups have all necessary dependencies. Several test dependencies (`hive-hcatalog-core:tests`, `hive-common`, `hive-cli`, `hive-hcatalog-core`) have been configured to exclude `joda-time` and `hive-exec` to prevent dependency conflicts. * **New Test Dependencies**: Added new test dependencies including `hive-standalone-metastore-common`, `hive-standalone-metastore-server`, `calcite-core`, and `datasketches-hive` to support comprehensive testing scenarios. * **Joda-Time Dependency**: `joda-time` has been explicitly added as both a `provided` and `testImplementation` dependency to manage its presence on the classpath. * **JVM Arguments for Tests**: JVM arguments `--add-opens=java.base/java.net=ALL-UNNAMED` have been added to all test tasks to address potential issues with Java module system restrictions during testing. * **Documentation Update**: The HCatalog documentation has been updated to reflect the use of the `core` classifier for the `hive-exec` dependency in Maven examples. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/io/hcatalog/build.gradle** * Updated `hive-exec` dependency to use the `core` classifier for `provided` scope. * Added `joda-time` as a `provided` and `testImplementation` dependency. * Modified `testImplementation` dependencies for `hive-hcatalog-core:tests`, `hive-common`, `hive-cli`, and `hive-hcatalog-core` to exclude `joda-time` and `hive-exec`. * Introduced new `testImplementation` dependencies for `hive-standalone-metastore-common`, `hive-standalone-metastore-server`, `calcite-core`, and `datasketches-hive`. * Added `--add-opens=java.base/java.net=ALL-UNNAMED` JVM argument to all test tasks. * **website/www/site/content/en/documentation/io/built-in/hcatalog.md** * Added `<classifier>core</classifier>` to the `hive-exec` dependency in the Maven example. </details> <details> <summary><b>Activity</b></summary> * No human activity has been recorded on this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
