kennknowles commented on code in PR #37792:
URL: https://github.com/apache/beam/pull/37792#discussion_r2897711369
##########
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Monitoring.java:
##########
@@ -240,123 +256,40 @@ static void incIfPresent(@Nullable Counter counter) {
@AutoValue.Builder
public abstract static class Builder {
- public abstract Builder setCountRequests(Boolean value);
+ public abstract Builder setCountRequests(boolean value);
- public abstract Builder setCountResponses(Boolean value);
+ public abstract Builder setCountResponses(boolean value);
- public abstract Builder setCountCalls(Boolean value);
+ public abstract Builder setCountCalls(boolean value);
- public abstract Builder setCountFailures(Boolean value);
+ public abstract Builder setCountFailures(boolean value);
- public abstract Builder setCountSetup(Boolean value);
+ public abstract Builder setCountSetup(boolean value);
- public abstract Builder setCountTeardown(Boolean value);
+ public abstract Builder setCountTeardown(boolean value);
- public abstract Builder setCountBackoffs(Boolean value);
+ public abstract Builder setCountBackoffs(boolean value);
- public abstract Builder setCountSleeps(Boolean value);
+ public abstract Builder setCountSleeps(boolean value);
- public abstract Builder setCountShouldBackoff(Boolean value);
+ public abstract Builder setCountShouldBackoff(boolean value);
- public abstract Builder setCountCacheReadRequests(Boolean value);
+ public abstract Builder setCountCacheReadRequests(boolean value);
- public abstract Builder setCountCacheReadNulls(Boolean value);
+ public abstract Builder setCountCacheReadNulls(boolean value);
- public abstract Builder setCountCacheReadNonNulls(Boolean value);
+ public abstract Builder setCountCacheReadNonNulls(boolean value);
- public abstract Builder setCountCacheReadFailures(Boolean value);
+ public abstract Builder setCountCacheReadFailures(boolean value);
- public abstract Builder setCountCacheWriteRequests(Boolean value);
+ public abstract Builder setCountCacheWriteRequests(boolean value);
- public abstract Builder setCountCacheWriteSuccesses(Boolean value);
+ public abstract Builder setCountCacheWriteSuccesses(boolean value);
- public abstract Builder setCountCacheWriteFailures(Boolean value);
+ public abstract Builder setCountCacheWriteFailures(boolean value);
abstract Optional<Boolean> getCountRequests();
- abstract Optional<Boolean> getCountResponses();
-
- abstract Optional<Boolean> getCountCalls();
Review Comment:
This one looks like it needs to be a `@Nullable Boolean`. Clearly there is
an intention that it could have three states: absent, true, or false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
