lostluck commented on code in PR #37673:
URL: https://github.com/apache/beam/pull/37673#discussion_r2898766230
##########
sdks/go/pkg/beam/runners/dot/dot.go:
##########
@@ -42,14 +47,74 @@ func Execute(ctx context.Context, p *beam.Pipeline)
(beam.PipelineResult, error)
return nil, errors.New("must supply dot_file argument")
}
- edges, nodes, err := p.Build()
+ edges, _, err := p.Build()
if err != nil {
return nil, errors.New("can't get data to render")
}
- var buf bytes.Buffer
- if err := dotlib.Render(edges, nodes, &buf); err != nil {
+ pipeline, err := graphx.Marshal(edges, &graphx.Options{})
+ if err != nil {
return nil, err
}
+
+ var buf bytes.Buffer
+ buf.WriteString("digraph G {\n")
+
+ components := pipeline.GetComponents()
+ if components == nil {
+ return nil, errNoComponents
+ }
+
+ transforms := components.GetTransforms()
+
Review Comment:
This can be ignored, as that's not a problem the runner should be dealing
with and indicates an issue with the submitting SDK.
##########
sdks/go/pkg/beam/core/util/dot/dot.go:
##########
@@ -14,6 +14,9 @@
// limitations under the License.
// Package dot produces DOT graphs from Beam graph representations.
+//
+// Deprecated:This package is no longer used by the Beam Go SDK.
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
