scwhittle commented on code in PR #37762:
URL: https://github.com/apache/beam/pull/37762#discussion_r2910775463
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindowingWindmillReader.java:
##########
@@ -126,7 +143,8 @@ public NativeReaderIterator<WindowedValue<KeyedWorkItem<K,
T>>> iterator() throw
windowsCoder,
valueCoder,
context.getWindmillTagEncoding(),
- context.getDrainMode());
+ context.getDrainMode(),
+ Boolean.TRUE.equals(skipDecodingExceptions.get()));
Review Comment:
Done, that seems safer and lets me cleanup the test where otherwise it was
required to set it. I think if using a real runner it always initializes all
the value providers during options deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
