scwhittle commented on code in PR #37797: URL: https://github.com/apache/beam/pull/37797#discussion_r2911254099
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java: ########## @@ -330,6 +330,7 @@ private StreamingDataflowWorker( } private StreamingWorkerHarnessFactoryOutput createApplianceWorkerHarness( + @UnderInitialization() StreamingDataflowWorker this, Review Comment: this is not actually a parameter you have to pass, this is a receiver parameter which lets us put an annotation on it. It has to be named this, see https://blog.joda.org/2015/12/explicit-receiver-parameters.html#:~:text=The%20receiver%20parameter%20is%20not,anything%20else%2C%20such%20as%20String%20. and https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#jls-8.4.1-220 ########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java: ########## @@ -368,6 +370,7 @@ private StreamingWorkerHarnessFactoryOutput createApplianceWorkerHarness( } private StreamingWorkerHarnessFactoryOutput createFanOutStreamingEngineWorkerHarness( + @UnknownInitialization() StreamingDataflowWorker this, Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
