gemini-code-assist[bot] commented on code in PR #37758:
URL: https://github.com/apache/beam/pull/37758#discussion_r2912716395
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java:
##########
@@ -1231,7 +1231,7 @@ public final boolean equals(Object o) {
}
UserStateCacheKeyBase other = (UserStateCacheKeyBase) o;
return hash == other.hash
- && this.getClass().equals(o.getClass())
+ && this.getClass().equals(other.getClass())
Review Comment:
While this change is cosmetic, the use of `getClass()` here will likely
still be flagged by the `EqualsGetClass` ErrorProne check. Since exact class
equality is desired for cache keys, this usage is valid. To align with the goal
of this PR and prevent future warnings, please add
`@SuppressWarnings("EqualsGetClass")` to the enclosing `equals` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
