kennknowles commented on code in PR #37631: URL: https://github.com/apache/beam/pull/37631#discussion_r2919627840
########## sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/ModelCoderRegistrar.java: ########## Review Comment: Specifically, I feel like right around here (or whoever accesses this?) we should provide a `getCoderTranslator(Class<Coder>)` method that can use the map but can also have more arbitrary logic, and that might be where we pass in the pipeline options and make a different decision based on them. Or have something other than static methods, like a CoderTranslatorProvider that is instantiated by giving it the pipeline options. That way, the options are plumbed in to the translation, but can be held in a field that isn't plumbed through a bunch of static methods, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
