PDGGK commented on PR #37516: URL: https://github.com/apache/beam/pull/37516#issuecomment-4046961603
Hi @kennknowles, sorry about that — the previous revision was sloppy and clearly not up to Beam's standards. I went back and reworked it properly: - Moved all inline fully-qualified names to proper imports - Stripped the excessive comments — the code should speak for itself - Switched from `indexByName` (which includes short aliases) to `indexNameById` so the drop logic only operates on canonical paths - Consolidated the two weak tests into one that uses `sameSchema()` for exact schema matching, same pattern as the existing `testProjectedSchema()` Appreciate the honest feedback. Please take another look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
