gemini-code-assist[bot] commented on PR #37845: URL: https://github.com/apache/beam/pull/37845#issuecomment-4052033768
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Dataflow streaming codebase by removing a feature flag (`useSeparateWindmillHeartbeatStreams`) that is no longer necessary. The flag, which controlled the use of separate streaming RPCs for Windmill heartbeats, has been fully rolled out since Beam version 2.61.0. The changes involve deprecating the option, simplifying related heartbeat sender logic, and cleaning up associated protocol buffer definitions and tests. ### Highlights * **Option Deprecation**: The `useSeparateWindmillHeartbeatStreams` option in `DataflowStreamingPipelineOptions` has been deprecated and marked as an unused flag. * **Heartbeat Sender Simplification**: The logic for conditionally creating `HeartbeatSender` based on the `useSeparateWindmillHeartbeatStreams` flag has been removed from `StreamingDataflowWorker`, simplifying the method signature and implementation. * **StreamPoolHeartbeatSender Refactoring**: An overloaded `create` method in `StreamPoolHeartbeatSender` that managed switching between heartbeat stream pools based on the flag has been removed, along with related imports. * **Test Cleanup**: Associated test cases in `StreamPoolHeartbeatSenderTest` that tested the flag's behavior have been deleted. * **Protocol Buffer Definition Update**: The `use_separate_windmill_heartbeat_streams` field has been removed from the `windmill.proto` definition, and its tag (2) has been reserved. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowStreamingPipelineOptions.java** * Deprecated the `getUseSeparateWindmillHeartbeatStreams` method. * Updated the description for `getUseSeparateWindmillHeartbeatStreams` to "Unused Flag". * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java** * Removed the import for `StreamingGlobalConfigHandle`. * Simplified the `createStreamingEngineHeartbeatSender` method call by removing parameters related to the removed flag. * Refactored the `createStreamingEngineHeartbeatSender` method to remove conditional logic based on the `useSeparateWindmillHeartbeatStreams` flag and related experiment checks. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/refresh/StreamPoolHeartbeatSender.java** * Removed the import for `StreamingGlobalConfigHandle`. * Deleted the overloaded `create` method that allowed switching between dedicated and general data stream pools for heartbeats based on global configuration. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/work/refresh/StreamPoolHeartbeatSenderTest.java** * Removed imports for `FakeGlobalConfigHandle`, `StreamingGlobalConfig`, and `UserWorkerRunnerV1Settings`. * Deleted test methods `sendsHeartbeatsOnDedicatedStream` and `sendsHeartbeatsOnGetDataStream`, along with the helper method `getGlobalConfig`, which tested the conditional behavior of the heartbeat stream pool based on the removed flag. * **runners/google-cloud-dataflow-java/worker/windmill/src/main/proto/windmill.proto** * Removed the `use_separate_windmill_heartbeat_streams` field from the `UserWorkerRunnerV1Settings` message. * Added `reserved 2;` to `UserWorkerRunnerV1Settings` to prevent future reuse of the field tag. </details> <details> <summary><b>Activity</b></summary> * No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
