scwhittle commented on PR #37723: URL: https://github.com/apache/beam/pull/37723#issuecomment-4066083459
validates runners tests still has some errors: https://github.com/apache/beam/runs/67043286782 Also not sure if the StreamingDataflowWorkerTest errors are real. They could be because you are using the executor now for the background thread and some tests uses a fake executor. https://github.com/apache/beam/blob/914e425b26daf26603bd5d0b5020b1c0ecd7a50c/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java#L4689 One idea (other than fixing that fake impl) woudl be to make the background cleanup thread lazily created whenever the first finalization is added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
