nikitagrover19 commented on PR #37345: URL: https://github.com/apache/beam/pull/37345#issuecomment-4127611773
@tvalentyn Following up on our earlier discussion - since there wasn’t further feedback on the issue, I went ahead and implemented the XLang-based approach you suggested. The latest commit reflects this, wiring `publish_with_ordering_key` through the Python external transform to Java PubSub IO, along with a couple of related fixes discovered during testing (including `pubsubRootUrl` handling and a `with_attributes` issue). The PR currently also retains the direct `_flush` fix in the Python SDK for completeness. Happy to scope this down if you'd prefer focusing solely on the XLang approach. Would appreciate your feedback on whether this direction looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
