ahmedabu98 commented on code in PR #37938:
URL: https://github.com/apache/beam/pull/37938#discussion_r2990176120


##########
sdks/python/apache_beam/yaml/tests/iceberg_add_files.yaml:
##########
@@ -75,3 +75,36 @@ pipelines:
               - {label: "3821b", rank: 3, bool: true}
               - {label: "990c", rank: 4, bool: true}
               - {label: "1024d", rank: 5, bool: false}
+
+  # Pipeline 4: Add an invalid file to trigger the DLQ
+  - pipeline:
+      type: composite
+      transforms:
+        - type: Create
+          config:
+            elements:
+              - {file: "gs://dummy-bucket/does-not-exist.txt"}

Review Comment:
   Thanks, this test made me realize I forgot to handle FileNotFound errors!
   
   Your test will still pass though, because `.txt` is an unsupported file 
format



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to