gemini-code-assist[bot] commented on PR #38008: URL: https://github.com/apache/beam/pull/38008#issuecomment-4160938612
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the vLLM worker in the text completion example could fail to initialize on GPUs with approximately 16GB of memory due to CUDA out-of-memory errors. By introducing configurable parameters for `max-num-seqs` and `gpu-memory-utilization`, the changes allow users to fine-tune vLLM's memory footprint, ensuring the example runs reliably on a wider range of hardware. The update includes both the implementation of these configuration options and clear documentation to guide users in optimizing their vLLM deployments. ### Highlights * **Memory Optimization for vLLM**: Introduced new command-line arguments `--vllm_max_num_seqs` and `--vllm_gpu_memory_utilization` to the `vllm_text_completion` example to prevent CUDA out-of-memory errors on GPUs with limited memory (e.g., 16GiB NVIDIA T4). * **Enhanced Example Configuration**: The `vllm_text_completion.py` example now allows users to explicitly configure vLLM server parameters, providing greater control over memory usage during engine startup and inference. * **Documentation Update**: Updated the `README.md` for the vLLM example to explain the purpose and usage of the new memory configuration parameters, guiding users on how to avoid common OOM issues. * **Model Handler Parameterization**: Modified `VLLMCompletionsModelHandler` and `VLLMChatModelHandler` instantiation in the example to accept and apply the new `vllm_server_kwargs`. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
